Allow multiple directories as plugin source by extending the plugin.dir
#26855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Oct 6, 2025
core/trino-main/src/main/java/io/trino/server/ServerPluginsProviderConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Oct 6, 2025
core/trino-main/src/main/java/io/trino/server/ServerPluginsProviderConfig.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Oct 6, 2025
core/trino-main/src/main/java/io/trino/server/ServerPluginsProviderConfig.java
Outdated
Show resolved
Hide resolved
gertjanal
force-pushed
the
multiple-plugin-dirs
branch
from
4652b0c to
5f2a1e2
Compare
Contributor
|
@gertjanal can you squash commits together and shorten the commit title?
|
gertjanal
force-pushed
the
multiple-plugin-dirs
branch
2 times, most recently
from
332f2d4 to
843c833
Compare
wendigo
reviewed
Oct 8, 2025
testing/trino-plugin-reader/src/main/java/io/trino/server/PluginReader.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
multiple-plugin-dirs
branch
from
843c833 to
17017a7
Compare
wendigo
approved these changes
Oct 8, 2025
gertjanal
force-pushed
the
multiple-plugin-dirs
branch
from
17017a7 to
2e012ef
Compare
Contributor
|
@gertjanal this rebase wasn't necessary. PRs are rebased automatically when built on the CI so there is rather small risk of logical conflict. At the same time rebases makes it harder for reviewers to use Github UI to check for diff. |
wendigo
force-pushed
the
multiple-plugin-dirs
branch
2 times, most recently
from
5547be6 to
1b31bd7
Compare
gertjanal
force-pushed
the
multiple-plugin-dirs
branch
from
1b31bd7 to
9a750ac
Compare
wendigo
force-pushed
the
multiple-plugin-dirs
branch
from
9a750ac to
0df6ef2
Compare
wendigo
force-pushed
the
multiple-plugin-dirs
branch
from
0df6ef2 to
1f1459a
Compare
pettyjamesm
reviewed
Oct 9, 2025
core/trino-main/src/main/java/io/trino/server/ServerPluginsProviderConfig.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
plugin.dirpoints to the directory in the Trino release where all default plugins are located.This PR allow multiple plugin directory locations, so externally added plugins can be located elsewhere.
plugin.dir=plugin,/mnt/external/trino-pluginsRelease notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: